chore(deps-dev): bump the jest-dependencies group with 2 updates #103412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
github-actions
bot
added
the
Scope: Frontend
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
41fc1fa to
4d5a4a5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "jest": "30.2.0", | ||
| "jest-canvas-mock": "^2.5.2", | ||
| "jest-environment-jsdom": "30.0.4", | ||
| "jest-environment-jsdom": "30.2.0", |
Contributor
There was a problem hiding this comment.
Bug: Jest Version Drift Causes Instability
The jest and jest-environment-jsdom packages were updated to 30.2.0, but babel-jest remains at 30.0.4 (line 201), creating a version mismatch within the Jest ecosystem. Jest packages from the same major version are designed to work together and should be kept in sync to avoid compatibility issues, test failures, or unexpected behavior during test execution.
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
4d5a4a5 to
542857e
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
542857e to
d3499b4
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
d3499b4 to
71781fa
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
71781fa to
3fe241b
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
3fe241b to
a06ac26
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
a06ac26 to
fea6d58
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
fea6d58 to
45aa78e
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
45aa78e to
242568f
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
242568f to
c612be6
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
c612be6 to
7e49a0f
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
219bc58 to
15cbe06
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
15cbe06 to
edfb8c9
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
edfb8c9 to
1a03946
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
2 times, most recently
from
5b83d5b to
823cf9b
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
823cf9b to
af29ae9
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
af29ae9 to
9012243
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
9012243 to
c8f342b
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
c8f342b to
1dfdc33
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
1dfdc33 to
dd0325a
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
dd0325a to
fe48f80
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
fe48f80 to
30aeb28
Compare
Bumps the jest-dependencies group with 2 updates: [jest](https://github.com/jestjs/jest/tree/HEAD/packages/jest) and [jest-environment-jsdom](https://github.com/jestjs/jest/tree/HEAD/packages/jest-environment-jsdom). Updates `jest` from 30.0.4 to 30.2.0 - [Release notes](https://github.com/jestjs/jest/releases) - [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/jestjs/jest/commits/v30.2.0/packages/jest) Updates `jest-environment-jsdom` from 30.0.4 to 30.2.0 - [Release notes](https://github.com/jestjs/jest/releases) - [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/jestjs/jest/commits/v30.2.0/packages/jest-environment-jsdom) --- updated-dependencies: - dependency-name: jest dependency-version: 30.2.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: jest-dependencies - dependency-name: jest-environment-jsdom dependency-version: 30.2.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: jest-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
from
30aeb28 to
c04b089
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "jest": "30.2.0", | ||
| "jest-canvas-mock": "^2.5.2", | ||
| "jest-environment-jsdom": "30.0.4", | ||
| "jest-environment-jsdom": "30.2.0", |
There was a problem hiding this comment.
Bug: Directly reassigning window.location in the afterEach hook of api.spec.tsx will throw a TypeError because JSDOM v26, introduced via the jest update, makes this property read-only.
Severity: HIGH
Suggested Fix
In the afterEach hook within static/app/api.spec.tsx, replace the direct assignment to window.location with a call to the existing setWindowLocation() helper function to restore the URL. Alternatively, remove the restoration logic entirely.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L224
Potential issue: The update to jest introduces JSDOM v26, which makes the
`window.location` property read-only and non-configurable. In `static/app/api.spec.tsx`,
the `afterEach` hook for the `resolveHostname` test suite attempts to restore the
original location by directly reassigning `window.location`. This will now throw a
`TypeError: Cannot set property location of #<Window> which has only a getter` at
runtime, causing all tests within that suite to fail during the cleanup phase.
Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
Author
|
Looks like these dependencies are no longer updatable, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/npm_and_yarn/jest-dependencies-57a1e19875
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the jest-dependencies group with 2 updates: jest and jest-environment-jsdom.
Updates
jestfrom 30.0.4 to 30.2.0Release notes
Sourced from jest's releases.
Changelog
Sourced from jest's changelog.
... (truncated)
Commits
855864ev30.2.0da9b532v30.1.3ebfa31cv30.1.2d347c0fv30.1.14d5f41dv30.1.022236cfv30.0.5Updates
jest-environment-jsdomfrom 30.0.4 to 30.2.0Release notes
Sourced from jest-environment-jsdom's releases.
Changelog
Sourced from jest-environment-jsdom's changelog.
... (truncated)
Commits
855864ev30.2.0ebfa31cv30.1.2d347c0fv30.1.14d5f41dv30.1.022236cfv30.0.5You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions